Increment/Decrement Tags With Drop
Open
Nobody has claimed this yet.
Question
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
Issue
Liquid allows render to be called with either a Hash, Context, or Drop. It appears that in the latter case, increment and decrement filters fail with Liquid error: internal because a drop is not writable to store the incrementing value of the counter.
Is this the expected behavior?
Sample Code:
Liquid::Template.parse('{%increment port %} {{ port }}').render(Liquid::Drop.new)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the sample using Liquid::Template.parse and render it with Liquid::Drop.new, then inspect how increment and decrement filters store their counters for a Drop. Done means the behavior is explicitly decided and covered for this case, without an unexplained internal error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100