Shopify / Shopify/liquid

v5.6.0: uninitialized constant Liquid::StrainerFactory (NameError)

Open
#1,877 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

Just want to open this issue if someone stumbles across the same error. Im not sure if StrainerFactory was an internal class. We only uesed it in one test.

There is a breaking change in v5.6.0

  • Removed StrainerFactory in favor of Environment-based strainer creation

The StrainerFactory got deprecated and removed in the same version

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no source file or test path; start by reading the v5.6.0 release note and the two linked commits, then locate the test that uses StrainerFactory. The issue does not define a requested fix or explicit completion criteria, so confirm the intended migration before making changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.