Shopify / Shopify/liquid

Add way to lazy load the poster preview `<img>` in `video_tag`/`media_tag` filters

Open
#1,825 1 comment 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

The video_tag and video_tag filters are very convenient, but they automatically generate a preview poster <img>, that we can not defer the loading of. This is especially frustrating when autoplay is true, because the image is not even seen by a user. It would be great if its loading could follow the same logic as the image_tag filter

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the existing video_tag and media_tag filter implementations, then compare their poster handling with image_tag's loading behavior. Completion means generated poster output follows the same loading logic, including autoplay cases; check the relevant filter tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.