Allow overriding blank? method in drops
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
Hi,
we just figured out that overriding the methods blank? or present? doesn't work to be overriden in drops, f.e. we would like to do following:
{% if user.account %}
{% else %}
{% endif %}
class AccountDrop < Liquid::Drop
def initialize(account)
@account = account
end
def blank?
@account.blank?
end
end
But it seems that this is not working? Also not with delegate or defs_delegators via forwardable ruby standard module?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Liquid::Drop and trace how blank? and present? are evaluated for drops in the conditional shown. Reproduce the AccountDrop example, including the Forwardable approach, and confirm that a drop can override the relevant behavior without breaking existing drop conditionals.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100