Shopify / Shopify/liquid

Should strip_newlines also 'strip' LSEP ?

Open
#1,804 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I have this issue where 'strip_newlines' filter is used, but it doesnt strip the 'LSEP' characters. Should the filter do this?

It's shown as "LSEP" by my editor or inspect in browser: \u2028

Screenshot 2024-06-03 at 13 39 37

I now have a workaround using the 'remove' but that feels verbose. Love to hear! Thanks.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and tests for the strip_newlines filter, then inspect how the \u2028 LSEP character is handled. Define the expected behavior for LSEP, add coverage for it, and verify that the filter's behavior matches the documented decision.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.