Shopify / Shopify/liquid

Liquid - Product Description Null Check Not Working

Open
#1,803 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

If condition in below code is failing: (Even when the description is blank, it print "About the product" header)

{% if product.description != "" and product.description != nil %}
About the product
{{product.description}}
{% endif %}

I have tried product.description != blank as well

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the reported Liquid conditional with a blank product.description, using the snippet in the issue as the entry point. Trace how != "" and != nil are evaluated; done when the header is omitted for a blank description while remaining shown for a populated one.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.