Add limit to split filter, like split method in Ruby
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
In Ruby language, the split method accepts an optional limit argument which is handy for the cases in which the user want to split the string into max number of chunks. It would be handy to have this feature in Liquid too.
I would like to implement it if there is no objection.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Liquid split filter implementation and compare its current behavior with Ruby's split method and optional limit argument. Add coverage for the limit behavior and verify that the filter produces no more than the requested number of chunks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- web-dev
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100