Shopify / Shopify/liquid

Regarding deprecation of the total_discount

Open
#1,799 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

As per your doc mentioned here, the total_discount property is deprecated.
Also, they have mentioned that it is replaced by line_item.total_discount.

So you said previously if it is already deprecated then we should able to get line_item.total_discount we are not getting it so this is the question regarding something not working as Shopify has mentioned in the Doc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No repository file or test is named. Start by comparing the linked Shopify Liquid documentation with the behavior of total_discount and line_item.total_discount, then determine whether the implementation or documentation is inconsistent. Done means the reported discrepancy is resolved or clearly documented with verified behavior.

Written by the indexing model from the issue text.

Assessment

Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.