Shopify / Shopify/liquid

video_tag fully disable poster

Open
#1,784 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I'm attempting to use videos as a progressive enhancement by displaying an image initially and then lazy loading the video. I render the image separately to allow uploading and support lazy loading.

Even though I have set the poster to an empty string, the <img> is still being rendered. Can you please provide a way to prevent this?

Setting image_size to x0 results in a 404 error, which is what I want, but without the error.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the video_tag implementation and trace how an empty poster and image_size are handled when rendering the <img> element. Done means there is a way to suppress that element without producing the 404 behavior caused by image_size set to x0.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.