Shopify / Shopify/liquid

Ruby 3.3 deprecation warnings: base64, bigdecimal will no longer be part of the default gems

Open
#1,772 1 comment 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Good first issue help wanted
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

liquid-5.4.0/lib/liquid/standardfilters.rb:4: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

/liquid-5.4.0/lib/liquid/standardfilters.rb:5: warning: bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec.

Since liquid does not have any dependencies in gemspec I don't feel like adding

if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('3.3')
  s.add_dependency('base64')
  s.add_dependency('bigdecimal')
end

so just leave this as issue, not PR

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/liquid/standardfilters.rb, especially the base64 and bigdecimal requires that produce the warnings, then inspect the gemspec and its dependency policy. Reproduce the warning on the affected Ruby version and confirm the chosen dependency declaration removes it without breaking supported versions or tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.