Shopify / Shopify/liquid

Can not use where filter on images

Open
#1,756 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

Since the image objects automatically outputs the handle by default, it's impossible to use the where filter on it.

{%- assign image = product.images | where: 'id', 123 -%}

This will result in storing the handle as a string in my assign, instead of storing it as an object.

I actually want to have the image object as an object by default and not as handle. Or we could do something like image.object for example.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by tracing how image objects are represented and how the where filter resolves values, then review existing coverage for image handles and object access; done when the intended image representation and filtering behavior are covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.