Shopify / Shopify/liquid

video_tag fallback image missing alt attribute

Open
#1,720 11 comments 9 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

video_tag fallback image missing alt attribute and triggering Lighthouse accessibility error:
https://shopify.dev/docs/api/liquid/filters/video_tag

image

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the video_tag filter and compare its fallback image output with the behavior documented at https://shopify.dev/docs/api/liquid/filters/video_tag. Reproduce the Lighthouse accessibility error, then verify that the fallback image includes an appropriate alt attribute and that the error no longer occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
accessibility
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.