Shopify / Shopify/liquid

where filter fails on comparing numeric values to strings with nested objects

Open
#1,709 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Report
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I have a nested object structure comes from here: https://shopify.dev/docs/api/liquid/objects/selling_plan_allocation

all the followings commands return empty:

variant.selling_plan_allocations | map: 'selling_plan'  | where: 'id', '123' | first
variant.selling_plan_allocations | where: 'selling_plan.id', '123' | first
variant.selling_plan_allocations | where: 'selling_plan.id', 123 | first

and this is the only thing works:

variant.selling_plan_allocations | map: 'selling_plan'  | where: 'id', 123 | first

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the four Liquid expressions in the issue and compare the results of nested versus mapped lookups. Trace the where filter entry point and its handling of numeric and string values, then add coverage for the reported cases. Done means the intended nested comparisons return the matching object consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.