Shopify / Shopify/liquid

Request: logical operators for “where” filter

Open
#1,707 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

This would enable some powerful features which currently require doing a lot of looping or repetitive concat assignments.

For example:

assign articles_with_tag = blog.articles | where: 'tags' contains 'tag-1'

or

assign interactive_media = product.media | where: 'media_type', 'model' or 'video' or 'external_video'

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by tracing the existing where filter implementation and how its arguments are parsed, then clarify the supported contains and or forms shown in the examples. Done means the requested logical filter expressions work without repetitive looping or concat assignments and have coverage for the stated examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.