Snippet generates extra unnecessary comments
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
- I want to use a snippet that converts hex to rgba:
<!-- color_to_rgba.liquid -->
{%-
liquid
assign rgb = color | color_to_rgb
assign tail = opacity | prepend: ', ' | append: ')'
-%}
{{ rgb | replace: 'rgb', 'rgba' | replace: ')', tail }}
- And it should returns the output so i can use it inside page CSS:
<!-- page.liquid -->
<style>
--converted-rgba-color: {{% render 'color_to_rgba', color: '#000', opacity: '0.5' %}}
</style>
- But instead of getting only the output, there is extra 2 wrapping comments i'm unable to get rid of:
<style>
--converted-rgba-color: <!-- BEGIN app snippet: test -->rgba(0, 0, 0, 0.5)<!-- END app snippet -->
</style>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the report with the color_to_rgba.liquid snippet rendered from page.liquid, and trace the snippet-rendering entry point that adds the wrapping comments. Confirm whether the generated CSS contains only rgba(0, 0, 0, 0.5); done means the extra BEGIN and END comments no longer appear around rendered snippet output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100