Request: Thousands and decimal separators on cart.currency
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
It would be great to be able to access the current currency’s thousands and decimals separators on the cart.currency object as currently there is no reliable way of getting them (for an example, see Dawn’s price range filter).
On a related note, it would be great to be able to access these on shop.currency as well, but that object seems to be more limited than cart.currency (for example, it does not have the symbol)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the cart.currency and shop.currency entry points and comparing the fields each object exposes. Determine the intended thousands and decimal separator values, including the related symbol limitation on shop.currency; done means both requested currency objects expose reliable separators with coverage for the relevant behavior.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100