Shopify / Shopify/liquid

`external_video_url` doesn’t update the `origin` URL parameter for YouTube videos

Open
#1,691 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

The external_video_url filter doesn’t update the origin URL parameter for YouTube embeds when using a preview URL. This is a URL parameter that the filter generates automatically. The origin mismatch breaks messaging to and from the iframe on preview URLs. The filter also includes the country part of the URL, breaking embed interaction on non-native-language stores.

Passing an explicit value to it with something like external_video_url: origin: request.origin doesn't seem to affect the output, the parameter is ignored.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the external_video_url filter and its YouTube URL parameter handling, then reproduce the preview URL and non-native-language store cases described in the issue. Done means the generated origin matches the preview URL, the country segment does not break embed interaction, and an explicit origin value is honored.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.