Shopify / Shopify/liquid

`{%- schema -%}` (with minuses) is not recognized properly

Open
#1,594 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

{%- schema -%}
  {
    "name": "My cool section"
  }
{%- endschema -%}

vs

{% schema %}
  {
    "name": "My cool section"
  }
{% endschema %}

The former results in error: 'schema' tag was never closed SyntaxError.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the two Liquid snippets in the issue and trace how the schema and endschema tags are recognized when whitespace-control minuses are present. Done means the {%- schema -%} form parses successfully while the existing {% schema %} form continues to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.