powered_by_link not providing an accessible warning
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
The powered_by_link object doesn't output a link that is deemed accessible enough.
The link is being opened in a new window/tab so having a warning for screen readers can be useful. We tend to add this behaviour on our Shopify flagship themes.
Here is the github issue from our public repo outlining the issue: https://github.com/Shopify/dawn/issues/720
We could create work around via JS but ideally we don't need to add extra logic like this to make the outcome of the object accessible.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the powered_by_link object in the Liquid repository and review how its link attributes are rendered. Read the linked Shopify Dawn issue for the accessibility context, then identify the relevant tests. Done means the generated link provides a screen-reader warning when it opens in a new window or tab, without requiring extra JavaScript.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- accessibility
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100