Shopify / Shopify/liquid

file download via `download` attr. or query-string `?dl`

Open
#1,575 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

https://developer.mozilla.org/de/docs/Web/HTML/Element/a#attr-download ; same DOMAIN issue if CDN is used

APACHE expl. for query-parameter dl

  RewriteCond %{QUERY_STRING} ^dl
  RewriteRule ^((.*/)*([^/]+\.[a-z]{2,4}))$ - [E=dlfilename:$3,E=fullpath:$1]
  Header onsuccess set Content-Disposition "attachment;filename=\"%{dlfilename}e\"" env=dlfilename
  Header onsuccess set Content-Location "/%{fullpath}e" env=dlfilename
  Header onsuccess set Link "</%{fullpath}e>; rel=\"canonical\"" env=dlfilename

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the linked MDN documentation for the HTML anchor download attribute and the Apache rewrite and header example in the issue. The issue names no Liquid files, entry points, or tests, so first determine whether this behavior belongs in Liquid and what repository-level acceptance criteria would define support.

Written by the indexing model from the issue text.

Assessment

Tech stack
apache, html
Domain
web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.