Shopify / Shopify/liquid

Rendering template whose name is stored in a variable issue

Open
#1,571 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

{% liquid
	assign path = 'path/to/file'
	render ""'path'
%}

This code will try to render the template whose path is path/to/file. This is probably not intended. Credit for this find goes to Rich Lane from One Orange Cow.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the render tag and variable interpolation behavior shown in the issue. Reproduce the Liquid snippet, establish the intended handling of the quoted variable, and add a regression test once the expected behavior is confirmed.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.