increment/decrement variable names are not validated
Open
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
Live Test Cases:
https://replit.com/@microalps/LiquidIncrementTests#main.rb
Expected behavior
- Using a variable name with a space should throw a syntax exception, e.g. {{ increment var var2 }}
- Using a variable name that has dot notation, bracket notation should either resolve to nested environment or throw syntax exception
Actual behavior
variable is treated as a single variable segment regardless of space, dot or bracket.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Live Test Cases at replit.com/@microalps/LiquidIncrementTests#main.rb and reproduce the increment/decrement examples involving spaces, dot notation, and bracket notation. Trace the corresponding variable-name handling and define completion as invalid names raising a syntax exception or resolving to nested environment values as specified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100