Shopify / Shopify/liquid

Include doesn't allow nested template name with length of 1 symbol

Open
#1,561 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

Continuation of https://github.com/dotliquid/dotliquid/issues/472

I want to include nested template via {% include 'B' %}, I have _B.liquid file near with my caller template.

Error: Liquid error: Error - Illegal template name 'B'

If I change B to BB, it starts to work.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with a caller template containing {% include 'B' %} and a nearby _B.liquid file, then trace how the include tag validates the template name. Done means a one-symbol nested template name such as B loads successfully, matching the existing behavior for BB.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.