Shopify / Shopify/liquid

reCAPTCHA removes form #id from success URL

Open
#1,511 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

When form submissions are interrupted by reCAPTCHA, the form #id is removed from the success URL. Since the #id is removed, the page doesn't jump down to see the success message.

{% form 'customer', id: 'ContactFooter' %}

Success
http://127.0.0.1:9292/?customer_posted=true#ContactFooter

Success after reCAPTCHA
http://127.0.0.1:9292/?customer_posted=true

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test entry point is named. Reproduce the customer form case with id ContactFooter, compare the normal and reCAPTCHA-interrupted success URLs, and trace the form-rendering path until the fragment is lost; done means the success URL retains #ContactFooter.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.