Shopify / Shopify/liquid

preload_tag, rel="preload" attribute added twice

Open
#1,500 6 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

The preload_tag is adding the rel="preload" attribute twice.

For example, here's the tag I'm using:

{{ 'Font-Name.woff2' | asset_url | preload_tag: as: 'font' }}

...and here's the outout:

<link href="Font-Name.woff2" rel="preload" as="font" rel="preload">

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the preload_tag filter implementation and inspect how the link attributes are assembled. Reproduce the provided Liquid example, then verify that the generated tag contains one rel="preload" attribute while retaining the as="font" attribute.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.