Shopify / Shopify/liquid

{%- schema -%} whitespace control

Open
#1,489 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Bug Report Parser
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

This works:

{%- schema -%}
  {
    "name": "Main",
    "settings": []
  }
{% endschema %}

...but adding whitespace control to the closing tag triggers a warning, 'schema' tag was never closed.

{%- schema -%}
  {
    "name": "Main",
    "settings": []
  }
{%- endschema -%}

Is it not possible to use whitespace control on {% schema %} tags?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the two schema-tag examples and compare the parser's handling of whitespace control on the opening and closing tags. Trace the schema tag parsing until the closing tag is recognized; done means the whitespace-controlled example no longer produces the 'schema' tag was never closed warning.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.