TAG filtering using URL - Include OR option instead of AND only.
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 11.9k
- Forks
- 1.5k
- Avg merge
- 17h 55m
- Merged PRs (30d)
- 3
Description
Hello,
I'm posting this in case it is better suited for this repository.
Summary
Using URL filtering regarding tags is amazing, but the fact that it only supports AND condition is seriously lacking.
Please implement a feature for OR tags.
Motivation
It is an extremely basic functionality that'd benefit a lot if not all shopify stores.
Using and paying for an app for such a simple functionality seems like waste of good potential as well as relying on external servers for the basic functionality.
The expected outcome would for URL to include some sort of a OR where tags of either side would be used to filter the results.
Describe alternatives you've considered
I've considered JavaScript solutions (ineffective), external applications (expensive) and attempted some solutions of my one that would count as hacks.
Thank you
Original issue: https://github.com/Shopify/shopify_app/issues/1222
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing URL tag-filtering implementation and its tests; no specific files or entry points are named in the issue. Clarify the intended URL syntax and precedence for OR conditions, then define tests showing that either tag can match before considering the implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- web-dev
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100