Shopify / Shopify/liquid

Shopify `t` filter doesn't allow `default:` filter

Open
#1,433 1 comment 8 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I'm not sure where to post this so I'm posting it here.

I'd like to allow for default language to be used or default filter fallback.

Is there any way to achieve this?

I'm trying to build the translation system around product tags. Some of these could be brand names so there's no need to translate those and default fallback would make perfect sense, but I cannot achieve this easily. I need to hack something along these lines:

Instead of:

{{ tag | t | default: tag }}

I have to do something along the lines of:

{% assign translated_tag = tag | t %}
{% if translated_tag contains 'translation missing' %}
  {% assign translated_tag = tag %}
{% endif %}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of the Liquid t filter and how filter chaining handles default:; the issue provides the two template examples to compare. Check whether missing translations can participate in the fallback and add coverage for the requested behavior, with the chained expression producing the original tag when translation is unavailable.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.