Shopify / Shopify/liquid

`endraw` Tag doesn't fully support Whitespace Controll

Open
#1,430 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I stumbled uppon this fact while trying to implement Whitespace Controll for the elixir Liquid library Solid
.

While all other tags(I think?) support whitespace controll even if they end up being a no-op like for the comment tag, the endraw tag doesn't parse correctly when left-whitespace-controll is added to it:

Input:

{% raw -%}

{{ 5 | plus: 6 }}

{%- endraw %} equals 11.
{% raw %} {{ {% {%  {% endraw %} equals 11.
{% raw %}{% increment counter %}{{ counter }}{% endraw %}
{% increment counter %} {{ counter }}

Output



{{ 5 | plus: 6 }}

{%- endraw %} equals 11.
{% raw %} {{ {% {%  equals 11.
{% increment counter %}{{ counter }}
0 1

Is this considered a bug or by design/won't fix?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the provided Liquid input and comparing it with the output, then trace how the raw/endraw tags parse whitespace control. Done means establishing the intended behavior and covering the endraw case with a regression test if it is confirmed as a bug.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.