Shopify / Shopify/liquid

"strict_variables" option does not take into account defaults

Open
#1,404 7 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I would like to use strict_variables: true, but it returns an error for an unassigned variable even if that variable has a default. Is there any way to throw an error if a variable is unassigned and doesn't contain a default?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by reproducing the strict_variables behavior with an unassigned variable that has a default, then trace how strict_variables and defaults are handled. Done means variables with defaults no longer raise an error while truly unassigned variables still do.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.