Shopify / Shopify/liquid

render vs include

Open
#1,288 13 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Question
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

Pardon me for being a bit late on this issue. While I understand the need for render and the benefits, I don't understand why include is being deprecated. Render is obviously a subset of include and therefore not exactly a replacement for include.

Specifically, I've used include as a way to mimic global values. That is, define a single file for globals and include that file as necessary. Include can kinda sorta function as a function - which I suppose is why there's render now (which again, makes sense for its intent) - but that "two way" communication of values (from child to parent) is gone.

What's the roadmap look like? How is include going to be fully replaced, because render is a significantly crippled version of include?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are mentioned. The issue asks for a roadmap explaining how include will be replaced and whether render can preserve include's behavior, so clarification from maintainers is needed before implementation can begin.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
web-dev
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
18/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.