Shopify / Shopify/liquid

Don't wrap Liquid output in quotations when using JSON filter

Open
#1,281 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Request
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

This is only related to the Shopify variation

The logic for this is counterproductive and should not be enforced when leveraging the | json filter. Please consider making quotation wrapping optional or not apply it all. Additionally when leveraging the json filter there are countless use cases where the automatically applied quotations get in the way of development. Thanks.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Begin by locating the Shopify-specific handling of the json filter and its quotation wrapping, then clarify whether wrapping should be optional or omitted; done means the chosen behavior is implemented and covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.