Shopify / Shopify/liquid

Liquid::Utils has no tests

Open
#1,156 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Important
Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

There are many filters relying on Liquid::Utils methods such as to_number, to_date etc however there are no tests covering these methods and their expected behavior.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Liquid::Utils and the existing filter tests that rely on methods such as to_number and to_date. Add coverage for the utilities' expected behavior, then run the relevant test suite to confirm these methods are tested without regressions.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.