Shopify / Shopify/liquid

Monorepo: Liquid-C

Open
#1,134 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
11.9k
Forks
1.5k
Avg merge
17h 55m
Merged PRs (30d)
3

Description

I wonder if we should pull the liquid-c code into this repository as the two projects really should move in unison. It would be much better if the test coverage of liquid always runs against liquid-c and liquid both to ensure that they keep working together. We should also annotate the methods of liquid that are later overridden in liquid-c to further clarify how it all works together.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing how this repository currently includes and tests Liquid, then identify where Liquid-C would be brought into the same repository and test flow. Check how Liquid methods overridden in Liquid-C are represented today. Done means both projects move together, Liquid’s tests run against both implementations, and the overridden methods are clearly annotated.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
build-system, testing-qa
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.