Spec generation appends modified liquid patches after previous ones
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 19
- Forks
- 8
- Avg merge
- 6h 41m
- Merged PRs (30d)
- 2
Description
When running either the generate:liquid_ruby or generate:standard_filters rake tasks, Helpers.insert_patch will be used to append a patch to liquid code under tmp/liquid if the patch isn't already included in that file. That means that if the file is modified, then it won't find it included and append the modified patch after the previous patch. This can lead to confusion and/or incorrect results when modifying that patch.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Helpers.insert_patch and the generate:liquid_ruby and generate:standard_filters rake tasks, then inspect how patches under tmp/liquid are detected. Reproduce the behavior by modifying an existing patch and rerunning generation. Done means regeneration does not append a second copy after the modified patch.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- testing, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100