Shopify / Shopify/liquid-spec

Add tests for ruby liquid that don't use assert_template_result

Open
#30 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
19
Forks
8
Avg merge
6h 41m
Merged PRs (30d)
2

Description

Currently, specs are generated from the https://github.com/Shopify/liquid repo by monkey patching assert_template_result and generating a test every time it is called. This means that it is missing test coverage for any tests that don't use that.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading how liquid-spec generates tests from the Shopify/liquid repository and how monkey-patching assert_template_result drives that process. Identify the entry points for tests that do not call assert_template_result, then add coverage for them and verify those tests are included in the generated suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.