Shopify / Shopify/liquid-spec

Make the Dawn specs run in SFR

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
19
Forks
8
Avg merge
6h 41m
Merged PRs (30d)
2

Description

After #17 is done, we should revisit the Dawn specs.

Dawn specs should be using the filters & drops from SFR. So, should be running in the SFR container.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #17 and the Dawn specs under specs/dawn, then identify the SFR container configuration and how the current specs are run. Done means the Dawn specs execute in the SFR container and use SFR's filters and drops.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.