Shopify / Shopify/liquid-spec

Run some specs as benchmarks

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
19
Forks
8
Avg merge
6h 41m
Merged PRs (30d)
2

Description

We'll need to keep track of performance, and know what to optimize.

I think if we could run existing specs (not all) as benchmarks, that would be a good start.

I imagine we could do:

bundle exec rake liquid_spec ... --benchmark --run 8 --warmup 5

The benchmarking logic should be similar to https://github.com/Shopify/liquid-wasm/blob/main/bench/run.rb.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the benchmarking logic in liquid-wasm's bench/run.rb and the existing liquid-spec Rake entry point. Determine how a selected subset of specs can support the shown --benchmark, --run 8, and --warmup 5 options. Done means the command runs selected existing specs as benchmarks and reports performance results.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
performance, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.