Shopify / Shopify/identity_cache
Remove :idc_cached_nil
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 2k
- Forks
- 174
- Avg merge
- 13m
- Merged PRs (30d)
- 3
Description
@dylanahsmith : "I think the only thing that prevented us from storing nil was that cache.read would return nil for a cache miss as well as if the value cached was nil. I think we may even be able to get rid of map_cached_nil_for now that we don't use cache.read."
Follow-up from #154
Note that support for cache.read was re-added in #161
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the cache.read path and the map_cached_nil_for reference, using the context from follow-ups #154 and #161 first. Determine whether :idc_cached_nil and map_cached_nil_for are still needed now that cache.read support was re-added; done means the obsolete handling is removed without breaking cache misses or cached nil values.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100