Shopify / Shopify/extensions-templates
Example targets in shopify extension toml file are incorrect.
Nobody has claimed this yet.
- Dominant language
- Liquid
- Stars
- 132
- Forks
- 23
- Avg merge
- 4d 13h
- Merged PRs (30d)
- 3
Description
Commented out targets in https://github.com/Shopify/extensions-templates/blob/main/admin-link/shopify.extension.toml.liquid#L29 did not seem to get updated with ad21711834d09a3f4e6a3c1f176a4875085519e6
Ie. admin.order-index.selection.action.link should be admin.order-index.selection-action.link
Maybe it would be better to just remove them and link to documentation for up to date target list?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open admin-link/shopify.extension.toml.liquid at line 29 and inspect the commented target examples, using the incorrect target named in the issue as the starting point. Update the examples to current target names, or replace them with a documentation link if that approach is chosen; done means no outdated target remains.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 50/100