Shopify / Shopify/discounts-reference-app
Commit or gitignore `dist` dir?
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 10
- Forks
- 5
- PR merge metrics
- No merged PRs in 30d
Description
I'm building a Shopify Function and Shopify CLI is generating files in dist directory, which is not gitignored.
Should I commit these files or I can gitignore them?
I couldn't find any mention of this anywhere in the docs.
https://shopify.dev/docs/apps/build/discounts/build-discount-function?extension=javascript
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Shopify discount function documentation and inspect how the Shopify CLI generates the dist directory for this JavaScript example. Determine whether generated files are intended to be committed or ignored, then document that guidance where the missing documentation belongs and update the repository guidance if needed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, javascript
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100