Shopify / Shopify/discount-app-components
[FEATURE] Add missing CustomerSegmentSelector component
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 87
- Forks
- 27
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 1
Description
Feature request summary
AppBridge resource picker does not have "CustomerSegment" resource type so I believe this issue should be resolved in @shopify/app-bridge-react first.
Rationale
This component is listed in the docs but cannot be found anywhere in the GitHub:
<CustomerEligibilityCard
eligibility={eligibilityField}
selectedCustomerSegments={selectedCustomerSegmentsField}
selectedCustomers={selectedCustomersField}
customerSegmentSelector={
<CustomerSegmentSelector
selectedCustomerSegments={selectedCustomerSegmentsField}
/>
}
customerSelector={
<CustomerSegmentSelector selectedCustomers={selectedCustomersField} />
}
/>
https://github.com/Shopify/discount-app-components/tree/main/src/components/CustomerEligibilityCard
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading src/components/CustomerEligibilityCard and the linked documentation example to understand the expected CustomerSegmentSelector usage. Investigate the AppBridge resource picker limitation described in the issue before choosing an implementation path. Done means the missing component is available in the library with the documented customer-segment selection behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100