CORS error on `shopify app dev` on the cli reverse proxy with `credentials: "include"`
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 750
- Forks
- 293
- Avg merge
- 3d 20h
- Merged PRs (30d)
- 79
Description
Hello, following this change, our local setup no longer works because we use credentials: "include" on some of our fetch requests to our backend.
This PR removes our Access-Control-Allow-Credentials: true header
Originally posted by @Dylan-GJ in https://github.com/Shopify/cli/issues/7164#issuecomment-5207778050
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reverse-proxy path used by shopify app dev and inspect the change referenced in the issue, focusing on how credentialed fetch requests are handled. Done means local backend requests using credentials: "include" no longer fail with a CORS error and the behavior is covered by an appropriate regression check.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- cli, networking
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100