Ability to fail the whole process if spinner fails
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 1.1k
- Forks
- 57
- Avg merge
- 2h 55m
- Merged PRs (30d)
- 2
Description
Currently, when the error is raised inside a Frame, the whole process is halt, see https://github.com/Shopify/cli-ui/blob/b9e35edf1345ab221e77097dfd0a4b9675d71636/lib/cli/ui/frame.rb#L127-L131
I would like to have a similar ability for spinners - to be able to pass some config option when creating a spinner, so that if it fails it halts the whole process. Currently, the spinner is only marked as failed and the process continues.
Are you open for such a feature? I can help with a PR.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read lib/cli/ui/frame.rb at lines 127-131 to compare the existing process-halting behavior, then trace the spinner creation and failure path. Define the configuration option and verify that a failed spinner halts the process while the default behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- cli
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100