Shopify / Shopify/cli-ui

Intermittent prompt_test failure

Open
#443 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Ruby
Stars
1.1k
Forks
57
Avg merge
2h 55m
Merged PRs (30d)
2

Description

e.g., https://github.com/Shopify/cli-ui/actions/runs/5314630194/jobs/9622054658?pr=429

Run options: --seed 63275

# Running:

........................................................F............................S...
rake aborted!

Command failed with status (1)
Finished in 23.282313s, 3.8226 runs/s, 11.[7](https://github.com/Shopify/cli-ui/actions/runs/5314630194/jobs/9622054658?pr=429#step:4:8)6[8](https://github.com/Shopify/cli-ui/actions/runs/5314630194/jobs/9622054658?pr=429#step:4:9)6 assertions/s.
/Users/runner/work/cli-ui/cli-ui/vendor/bundle/ruby/3.0.0/gems/rake-13.0.6/exe/rake:27:in `<top (required)>'

/Users/runner/hostedtoolcache/Ruby/3.0.6/x64/bin/bundle:23:in `load'
  1) Failure:
/Users/runner/hostedtoolcache/Ruby/3.0.6/x64/bin/bundle:23:in `<main>'
CLI::UI::PromptTest#test_confirm_sigint [/Users/runner/work/cli-ui/cli-ui/test/cli/ui/prompt_test.rb:26]:
Tasks: TOP => default => test
(See full trace by running task with --trace)
Expected "" to include "sentinel".

8[9](https://github.com/Shopify/cli-ui/actions/runs/5314630194/jobs/9622054658?pr=429#step:4:10) runs, 274 assertions, 1 failures, 0 errors, 1 skips

I tried TESTOPTS="--seed=63275" bundle exec rake on my Macbook, but it's passing there.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with test/cli/ui/prompt_test.rb at line 26 and reproduce the reported seed with TESTOPTS="--seed=63275" bundle exec rake. Compare the CI failure, where CLI::UI::PromptTest#test_confirm_sigint expected "sentinel", with the passing MacBook run. Done means the prompt test no longer fails intermittently in the reported test run.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
cli, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.