Shopify / Shopify/buy-button-js
Remove focus outline on cart close button
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 260
- Forks
- 122
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 2
Description
On chrome whenever the cart is toggled open it auto-focuses on the close button which renders the ugly grey outline. Can someone please add "outline: none;" to that button so it removes that? Or just don't auto-focus the close button.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the cart toggle behavior and locating the close button's focus handling and styles. Confirm the intended approach with the existing UI behavior, then verify that opening the cart no longer produces the unwanted outline or focus behavior described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100