Shopify / Shopify/buy-button-js

Update browser support April 2017

Open
#360 0 comments 0 reactions 1 assignee View on GitHub

@harisaurus is already working on this.

Since Feb 23, 2017.

tech debt
Dominant language
JavaScript
Stars
260
Forks
122
Avg merge
5d 14h
Merged PRs (30d)
2

Description

In April 2017 Microsoft will drop extended support for vista, the last OS to support IE9/10. Once IE9/10 support is dropped the following simplifications can be made:

  • remove element-class utils and replace with Element.classList
  • remove frame-utils and replace with requestAnimationFrame
  • remove detect-features and associated conditional checks for feature support
  • replace Element.getAttribute('data-x') with Element.dataset
  • remove conditional stylesheet include and related code in iframe class
  • remove conditional.scss and related build code
  • remove ie9 ajax from js-buy-sdk and use regular xhr/fetch
  • update support table in docs on both js-buy-sdk and buy-button-js

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.