Shopify / Shopify/async-memcached
Crate does not compile on Windows
Open
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 16
- Forks
- 5
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 2
Description
On Windows, this crate fails to compile, with Error: unresolved import 'tokio::net::UnixStream':
Compiling async-memcached v0.5.0
error[E0432]: unresolved import `tokio::net::UnixStream`
--> C:\...\async-memcached-0.5.0\src\connection.rs:6:53
|
6 | use tokio::net::{lookup_host, TcpSocket, TcpStream, UnixStream};
| ^^^^^^^^^^ no `UnixStream` in `net`
|
note: found an item that was configured out
--> C:\...\tokio-1.43.0\src\net\mod.rs:58:27
|
58 | pub use unix::stream::UnixStream;
| ^^^^^^^^^^
note: the item is gated here
--> C:\...\tokio-1.43.0\src\net\mod.rs:54:1
|
54 | / cfg_net_unix! {
55 | | pub mod unix;
56 | | pub use unix::datagram::socket::UnixDatagram;
57 | | pub use unix::listener::UnixListener;
58 | | pub use unix::stream::UnixStream;
59 | | pub use unix::socket::UnixSocket;
60 | | }
| |_^
= note: this error originates in the macro `cfg_net_unix` (in Nightly builds, run with -Z macro-backtrace for more info)
connection.rs unconditionally imports tokio::net::UnixStream, which is cfg'd out on Windows.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in connection.rs and reproduce the Windows build failure involving the unconditional tokio::net::UnixStream import. Check how the connection code handles Unix sockets, then verify that the crate compiles successfully on Windows without importing the Unix-only type.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100