Shopify / Shopify/app_profiler
Refactor vernier support logic
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 268
- Forks
- 14
- Avg merge
- 1h 9m
- Merged PRs (30d)
- 1
Description
We use a defined? check to make sure the vernier constant can be loaded. Instead, we should be able to determine which config option maps to what backend without loading said backend. This was recently re-added to App Profiler in https://github.com/Shopify/app_profiler/pull/154 after the behaviour regressed. So, I'd like to:
- Change the vernier branching logic not use
defined?by keeping backend names outside of their respective constants that load peer dependency gems. - Make stackrof a peer dependency as well (if it isn't already).
- Add tests to make sure we don't regress.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the vernier branching logic and the dependency declarations, then compare the regression fix in App Profiler pull request 154. Trace how backend names are currently tied to constants that load peer gems, including stackrof. Add regression coverage for selecting backends without loading them and verify the project tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100