Serial-ATA / Serial-ATA/lofty-rs
ID3v2: URIs in APIC frames are not parsed
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 359
- Forks
- 77
- Avg merge
- 12h 54m
- Merged PRs (30d)
- 11
Description
ID3v2 allows for URIs to the image in the APIC tag. This is currently ignored and will not parse the image.
https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#apic
I thought about implementing this functionality myself but the URI could point to a file or a image on the web. Since I don't think lofty should connect to the internet on it's own I would suggest to just return the URI.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the ID3v2 APIC frame parser and reading the linked ID3v2 specification section. Check how image data is currently handled and add coverage for an APIC image URI; done means the URI is returned without making an internet connection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- audio-video-rtc
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100